Rholang Sprint 16 Retrospective
Retrospective
What did we do well?
- Medha Parlikar (Unlicensed): We completed several large features, Name Registry & Validator bonding
- Kyle Butt: Uncommon Ancestor Algorithm implemented. Nice work Michael Birch (Unlicensed) & Kyle Butt.
- Medha Parlikar (Unlicensed): Amazing progress on Cost Accounting. Shout out to Mateusz Gorski (Unlicensed).
- Mateusz Gorski (Unlicensed): we found the issue with matching in RSpace. We learned about it pretty early in the project.
What should we have done better?
- Artur Gajowy: We should make sure our work is broken up into reviewable PR's. Tickets should take ~ 1-3 days. PR's should happen every ~ 1-3.
- Ovidiu Deac: Don't perform refactoring + net new logic work in the same pull request. If you need refactoring as part of your implementation, cut a PR for your refactoring/reformatting first and separately - check for clean tests. Makes it easier. Then create a PR for the new features.
- Artur Gajowy: Whenever you are changing repetitive code (modify it in different places) - step back and extract the duplicated function first. The worst thing that can happen is that you have improved the code quality. The best thing to happen is that you have reduced the size of the Pull Request.
Actions:
- Type your task here, using "@" to assign to a user and "//" to select a due date